ObservableList Replace Bugfix

When replacing, the callback function should refer to the item in the array, rather than generating a new one.
NeverMorewd · Mar 20, 2024 · 5b50267 · 5b50267
1 parent 20a1c35
commit 5b50267
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ObservableCollections/ObservableList.Views.cs b/src/ObservableCollections/ObservableList.Views.cs
@@ -212,7 +212,7 @@ private void SourceCollectionChanged(in NotifyCollectionChangedEventArgs<T> e)
                             // ObservableList does not support replace range
                         {
                             var v = (e.NewItem, selector(e.NewItem));
-                            var ov = (e.OldItem, selector(e.OldItem));
+                            var ov = (e.OldItem, list[e.OldStartingIndex].Item2);
                             list[e.NewStartingIndex] = v;
                             filter.InvokeOnReplace(v, ov, e.NewStartingIndex);
                             break;
@@ -240,4 +240,4 @@ private void SourceCollectionChanged(in NotifyCollectionChangedEventArgs<T> e)
             }
         }
     }
-}
+}