Repository navigation
fix(agentic): validate RecallFile pagination inputs - #663
Merged
MrXnneHang merged 1 commit intoAug 26, 2026
Merged
Conversation
MrXnneHang
self-requested a review
August 24, 2026 01:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #662
Summary
Validate RecallFile pagination inputs at the shared AgenticMixin service boundary before repository access.
Root cause
The pagination feature added
_decode_cursor()and forwardedlimitdirectly tolist_recall_files_page(). Malformed cursors leaked decoder and tuple-unpacking exceptions, whilelimit=0reached backend implementations without a shared contract.Changes
limit < 1withValueError("limit must be greater than zero").ValueError("invalid cursor").Validation
tests/test_agentic.py -q: 32 passedsrc/memu/app/agentic.py: passedgit diff --check: passedThis PR is based on the latest upstream
mainat commit37d2efa.