Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for documents #49

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Add support for documents #49

merged 2 commits into from
Jan 4, 2023

Conversation

taylorgibb
Copy link
Contributor

@taylorgibb taylorgibb commented Jan 4, 2023

When sending a document this is the response, this adds a helper method like files and images have to get the document reference so we can download the attachment.

image

@taylorgibb
Copy link
Contributor Author

Tested as below, works well, can we get this merged in so i can update our package from pip ?

image

@Kalebu
Copy link
Contributor

Kalebu commented Jan 4, 2023

Hi @taylorgibb

Thanks for taking your time to contribute

Merging this

@Kalebu Kalebu merged commit 9350370 into Neurotech-HQ:main Jan 4, 2023
@taylorgibb
Copy link
Contributor Author

Thank you so much, much appreciated! Thanks for the work on this library as well!

@taylorgibb taylorgibb deleted the patch-1 branch January 5, 2023 05:33
@taylorgibb
Copy link
Contributor Author

@Kalebu any idea when you will be able to publish this to pip ?

@Kalebu
Copy link
Contributor

Kalebu commented Jan 5, 2023

There was no definite like circle to publish to PyPI but I will definitely do it this week

Have two questions ASAP

  1. Does this pull request also fix issue get_file function not implemented #45
  2. Do you also have spare time to work on Add functionality to send_sticker #43?

Thank you @taylorgibb

@taylorgibb
Copy link
Contributor Author

Yes it does fix #45 but i suppose i should update the docs and the sample hook as well. Ill send a separate PR for that later today as there is not concept of message_type file anymore, Whatsapp is now sending them as message_type document.

I can take a look at #43, i just want to get our project over the line first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants