Conversation
bendichter
reviewed
Apr 7, 2021
Co-authored-by: Ben Dichter <ben.dichter@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 69.15% 68.91% -0.25%
==========================================
Files 30 30
Lines 2169 2184 +15
==========================================
+ Hits 1500 1505 +5
- Misses 669 679 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
@luiztauffer see edits to my comment. You may have to test it a bit. I'm not 100% sure it will work as I wrote it |
Collaborator
|
Now that I am thinking about it, maybe the values of |
Collaborator
Author
|
@bendichter I agree, at least with most of the items. It makes adding custom widgets easy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows user-created widgets to be included in the
neurodata_vis_spec, can be used like this:For now it only works for items which are
OrderedDict. Maybe we would like to extend most items to beOrderedDict? This would in principle just nest each item in a single Tab, but allows for the possibility of easily adding customized widgets