Skip to content

Remove deprecated warning in version submodule#667

Open
bendichter wants to merge 2 commits intodevfrom
bendichter-patch-2
Open

Remove deprecated warning in version submodule#667
bendichter wants to merge 2 commits intodevfrom
bendichter-patch-2

Conversation

@bendichter
Copy link
Contributor

I don't see a need to deprecate this. This is the way most people check for version

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the common pattern is:

from nwbinspector import __version__

Not the one here which is:
from nwbinspector.version import __version__

I do like removing code for the sake of token efficiency for our robot overlords, but I don’t think it matters in this case. I’d say it’s your call whether you remove the code or the warning.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.80%. Comparing base (73f9948) to head (20308ad).
⚠️ Report is 7 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #667      +/-   ##
==========================================
+ Coverage   77.64%   81.80%   +4.16%     
==========================================
  Files          47       47              
  Lines        1673     1737      +64     
==========================================
+ Hits         1299     1421     +122     
+ Misses        374      316      -58     
Files with missing lines Coverage Δ
src/nwbinspector/version/__init__.py 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants