Remove deprecated warning in version submodule#667
Open
bendichter wants to merge 2 commits intodevfrom
Open
Conversation
Removed deprecation warning for version import.
h-mayorquin
approved these changes
Feb 18, 2026
Collaborator
h-mayorquin
left a comment
There was a problem hiding this comment.
I think the common pattern is:
from nwbinspector import __version__
Not the one here which is:
from nwbinspector.version import __version__
I do like removing code for the sake of token efficiency for our robot overlords, but I don’t think it matters in this case. I’d say it’s your call whether you remove the code or the warning.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #667 +/- ##
==========================================
+ Coverage 77.64% 81.80% +4.16%
==========================================
Files 47 47
Lines 1673 1737 +64
==========================================
+ Hits 1299 1421 +122
+ Misses 374 316 -58
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see a need to deprecate this. This is the way most people check for version