Fixed JSON encoding of importance used as keys#397
Draft
CodyCBakerPhD wants to merge 2 commits intodevfrom
Draft
Fixed JSON encoding of importance used as keys#397CodyCBakerPhD wants to merge 2 commits intodevfrom
CodyCBakerPhD wants to merge 2 commits intodevfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #396 as well as unreported issue on the GUIDE (Slack communication)
Motivation
Importance classes when used as dictionary keys using the return of
organize_messages(..., levels=[..., "importance"])were not dumpable to JSON, even when using our encoderThis fixes the encoder, allowing the organized message stream to be serialized in JSON manner
TODO: need to add tests