-
Notifications
You must be signed in to change notification settings - Fork 11
[Read Helpers IIb] Add read_nwbfile with Pytest fixtures #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
…outborders/nwbinspector into add_read_nwbfile_2
|
The CI has trouble untangling the HDMF versioning, but manual local dev installation of each package allows the tests to run Getting some actual legit errors now though, beginning debugging now |
for more information, see https://pre-commit.ci
|
Update: the However the other tests related to deletion are legitimately failing locally, so hdmf-dev/hdmf#882 might need some more investigation |
|
Notes from convo: *add tests for fsspec
|
…atawithoutborders/nwbinspector into add_read_nwbfile_fixtures
for more information, see https://pre-commit.ci
…atawithoutborders/nwbinspector into add_read_nwbfile_fixtures
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…atawithoutborders/nwbinspector into add_read_nwbfile_fixtures
…atawithoutborders/nwbinspector into add_read_nwbfile_fixtures
|
@bendichter All tests green now |
| - name: Install HDMF-zarr # temporary | ||
| run: pip install hdmf-zarr | ||
| - name: Install latest HDMF # temporary | ||
| run: pip install -U hdmf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it might be better to switch to a requirements-tests.txt file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary b/c of hdmf-zarr's dependencies - it's normally not needed at all for that workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the goal here is not to make such things directly be base requirements of nwbinspector (instead relying on pynwb to handle it); this is only temporary stuff for running the tests that will be ported to PyNWB after thorough evaluation using the NWB Inspector
Analog of #386 but using pytest fixtures instead of
unittest.TestCase