Skip to content

Conversation

@CodyCBakerPhD
Copy link
Contributor

Analog of #386 but using pytest fixtures instead of unittest.TestCase

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jul 10, 2023
@CodyCBakerPhD CodyCBakerPhD changed the base branch from dev to reorganize_tools July 10, 2023 18:34
@CodyCBakerPhD
Copy link
Contributor Author

The CI has trouble untangling the HDMF versioning, but manual local dev installation of each package allows the tests to run

Getting some actual legit errors now though, beginning debugging now

@CodyCBakerPhD
Copy link
Contributor Author

Update: the test_<backend>_explicit_closure tests are passing for both backends now

However the other tests related to deletion are legitimately failing locally, so hdmf-dev/hdmf#882 might need some more investigation

@bendichter
Copy link
Contributor

bendichter commented Jul 10, 2023

Notes from convo:

*add tests for fsspec

  • https and s3

  • hdf5 and zarr

  • add tests for ros3 (just for hdf5)

Base automatically changed from reorganize_tools to dev July 10, 2023 20:50
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 7, 2023 19:44
@CodyCBakerPhD
Copy link
Contributor Author

@bendichter All tests green now

Comment on lines +29 to +32
- name: Install HDMF-zarr # temporary
run: pip install hdmf-zarr
- name: Install latest HDMF # temporary
run: pip install -U hdmf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it might be better to switch to a requirements-tests.txt file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary b/c of hdmf-zarr's dependencies - it's normally not needed at all for that workflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the goal here is not to make such things directly be base requirements of nwbinspector (instead relying on pynwb to handle it); this is only temporary stuff for running the tests that will be ported to PyNWB after thorough evaluation using the NWB Inspector

@CodyCBakerPhD CodyCBakerPhD merged commit 35b901e into dev Aug 16, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the add_read_nwbfile_fixtures branch August 16, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants