Skip to content

Commit

Permalink
Sort input file list
Browse files Browse the repository at this point in the history
so that _ubjson.so builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

This PR was done while working on reproducible builds for openSUSE.
  • Loading branch information
bmwiedemann authored and vtermanis committed Apr 9, 2019
1 parent d4050c2 commit d1f0d9f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def build_extension(self, ext):
license='Apache License 2.0',
packages=['ubjson'],
zip_safe=False,
ext_modules=([Extension('_ubjson', glob('src/*.c'), extra_compile_args=COMPILE_ARGS)]
ext_modules=([Extension('_ubjson', sorted(glob('src/*.c')), extra_compile_args=COMPILE_ARGS)]
if BUILD_EXTENSIONS else []),
cmdclass={"build_ext": BuildExtWarnOnFail},
keywords=['ubjson', 'ubj'],
Expand Down

0 comments on commit d1f0d9f

Please sign in to comment.