Skip to content

Conversation

toddrjen
Copy link
Contributor

@toddrjen toddrjen commented Feb 6, 2014

These commits remove the last traces of description.py. All functionality is now moved into the classes themselves, with the except of class_by_name which is moved into neo/core/init.py.

The only functionality that was removed was the name_by_class dict. The same information can be obtained faster and more clearly by changing name_by_class[cls] to cls.name. There are also ways to do class_by_name but they are slightly slower and less clear.

@samuelgarcia
Copy link
Contributor

I would also like something more flexibe for attributes description, using dict and str only.

like thi:

_necessary_attrs = [{'name' : 'time', 'type' : 'quantities', 'ndim' : 1 },
{'name' : 'signal', 'type' : 'numpy', 'ndim' : 3 },
{'name' : 'rec_datetimel', 'type' : 'datetime', },]

I can do the work if you want.

@toddrjen
Copy link
Contributor Author

toddrjen commented Feb 7, 2014

I had a similar idea but slightly different details.

However, I am trying to keep the amount of API change in any single pull request and commit smaller in order to make bisecting bugs easier.

So if possible, let's keep the API in the pull request more of a strict refactoring, then we can discuss how to more fundamentally improve the API in a separate issue. Is that okay?

@samuelgarcia
Copy link
Contributor

You are right. The merge is OK me.
Could you open an issue to discuss first on this API ?

toddrjen added a commit that referenced this pull request Feb 10, 2014
Remove description.py entirely
@toddrjen toddrjen merged commit 9fe203a into NeuralEnsemble:master Feb 10, 2014
@toddrjen toddrjen deleted the no_description branch February 10, 2014 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants