Automatic handling of relationships between objects#1266
Automatic handling of relationships between objects#1266JuliaSprenger merged 11 commits intoNeuralEnsemble:masterfrom
Conversation
…tructors of Block, Segment, Group, instead of doing it in the parent class Container.
…ce Neo no longer has any such relationships
Note that this removes the need for `create_relationship()` except with deepcopy.
| # but this will need substantial changes to container handling | ||
| self._segments = ObjectList(Segment, parent=self) | ||
| self._groups = ObjectList(Group, parent=self) | ||
| self._regionsofinterest = ObjectList(RegionOfInterest, parent=self) |
There was a problem hiding this comment.
Should regions of interest really be linked to a block and not a handled on the same level as a view?
| nlines = 1.5 | ||
| nlines += len(getattr(obj, '_all_attrs', [])) | ||
| nlines += len(getattr(obj, '_single_child_objects', [])) | ||
| nlines += len(getattr(obj, '_multi_child_objects', [])) |
There was a problem hiding this comment.
This script is currently not running due to some imports not being present. I think it would help to also include the generated diagram to understand the structural changes here.
There was a problem hiding this comment.
@apdavison : do you plan to tedisouly also fix the diagram generator or will we fix this later ?
| self._epochs = ObjectList(Epoch) | ||
| self._channelviews = ObjectList(ChannelView) | ||
| self._imagesequences = ObjectList(ImageSequence) | ||
| self._segments = ObjectList(Segment) # to remove? |
There was a problem hiding this comment.
I vote for the removal of segments here to simplify the neo structure.
There was a problem hiding this comment.
I am OK with this. This can be done outside the PR no ?
|
Hi. |
|
Yes, we from my side we can merge this and fix the neo structure in another PR similar to #1026 |
3 participants
another attempt to implement #125 (replaces #588)