Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to MEArecRawIO for loading only recordings or only sorting data #1258

Merged
merged 8 commits into from
May 2, 2023

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Apr 18, 2023

Right now MEArecRawIO loads all the data (recording and sorting) by default. This PR leaves that default as it is but also adds the option of only loading recording or sorting data with a boolean value at __init__.

With this, the intialization of the object -specially the recoder- should be lighter as it does not need to go through the spiking data in mearec.

I added tests for both of these modes.

@alejoe91
Copy link
Contributor

Thanks @h-mayorquin! This will make reading MEArec files much faster and getting the number of channels in a more robust way

@JuliaSprenger
Copy link
Member

Hi @h-mayorquin Could you also add the new arguments to the MeaRecIO, to be available also for the non-rawio?

@h-mayorquin
Copy link
Contributor Author

@JuliaSprenger should be done.

@DradeAW
Copy link

DradeAW commented Apr 24, 2023

If this is done, could it be merged? :)

Thanks

@h-mayorquin
Copy link
Contributor Author

h-mayorquin commented Apr 24, 2023

Edit: Mistake comment.

@samuelgarcia
Copy link
Contributor

This is cool.
Here in neo we do not have the naming recording which is very very confusing.
I would change it to load_analogsignal'

@h-mayorquin
Copy link
Contributor Author

I changed load_recordings to load_analogsignal

@h-mayorquin
Copy link
Contributor Author

h-mayorquin commented Apr 27, 2023

I implemented @samuelgarcia feedback now.

@JuliaSprenger
Copy link
Member

@samuelgarcia Are you happy with the changes? Then feel to merge.

@samuelgarcia
Copy link
Contributor

merci @h-mayorquin

@samuelgarcia samuelgarcia merged commit 33b05b6 into NeuralEnsemble:master May 2, 2023
@h-mayorquin h-mayorquin deleted the improve_mearec branch May 2, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants