-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to MEArecRawIO
for loading only recordings or only sorting data
#1258
Add option to MEArecRawIO
for loading only recordings or only sorting data
#1258
Conversation
Thanks @h-mayorquin! This will make reading MEArec files much faster and getting the number of channels in a more robust way |
Hi @h-mayorquin Could you also add the new arguments to the MeaRecIO, to be available also for the non-rawio? |
@JuliaSprenger should be done. |
If this is done, could it be merged? :) Thanks |
Edit: Mistake comment. |
This is cool. |
I changed |
I implemented @samuelgarcia feedback now. |
@samuelgarcia Are you happy with the changes? Then feel to merge. |
merci @h-mayorquin |
Right now
MEArecRawIO
loads all the data (recording and sorting) by default. This PR leaves that default as it is but also adds the option of only loading recording or sorting data with a boolean value at__init__
.With this, the intialization of the object -specially the recoder- should be lighter as it does not need to go through the spiking data in mearec.
I added tests for both of these modes.