Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the Terraform infrastructure by removing custom module abstractions and consolidating everything into flat, self-contained configuration files. The changes make the infrastructure more accessible to developers unfamiliar with Terraform by eliminating indirection and providing comprehensive inline documentation.
Key Changes:
- Removed all custom Terraform modules (az-naming, az-resource-group, az-container-app, az-container-app-env)
- Inlined Container App resource directly into main.tf with explicit configuration
- Enhanced documentation with detailed comments and expanded README
- Removed legacy Azure DevOps pipeline file
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Infrastructure/Terraform/variables.tf | Reorganized with improved descriptions and better grouping by purpose |
| Infrastructure/Terraform/main.tf | Replaced module calls with inline Container App resource definition |
| Infrastructure/Terraform/providers.tf | Added explanatory comments for backend and provider configuration |
| Infrastructure/Terraform/outputs.tf | New file exposing Container App URLs and metadata |
| Infrastructure/Terraform/README.md | Completely rewritten with beginner-friendly documentation and examples |
| Infrastructure/Terraform/tf-modules/* | Removed all custom module directories |
| Infrastructure/Terraform/pipelines/helloworld-tf-pipeline.yml | Removed legacy pipeline file |
| Infrastructure/Terraform/AGENTS.md | Removed AI agent guidelines document |
| CLAUDE.md | Updated to reflect Terraform changes and removed Bicep references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### 1. Reference Existing Infrastructure | ||
| ```hcl | ||
| data "azurerm_resource_group" "rg" { | ||
| name = var.resource_group_name |
There was a problem hiding this comment.
The example references var.resource_group_name, but the actual variable name is var.existing_cae_resource_group_name according to variables.tf. This inconsistency could confuse readers following the documentation.
| name = var.resource_group_name | |
| name = var.existing_cae_resource_group_name |
No description provided.