Skip to content

Conversation

@khalifaa55
Copy link
Contributor

@khalifaa55 khalifaa55 commented Oct 20, 2025

Changes:

  • Update Lido CSM contracts ABI
  • Update claimRewards link
  • Remove stuck and refunded keys metrics
  • Update penalties events
  • Update rewards ipfs
  • Remove holesky test cases for Lido CSM integration

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@khalifaa55 khalifaa55 self-assigned this Oct 20, 2025
@khalifaa55 khalifaa55 marked this pull request as draft October 20, 2025 17:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 10.46278% with 445 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.13%. Comparing base (1fda2e9) to head (a0ba6f9).

Files with missing lines Patch % Lines
.../lido/contracts/csexitpenalties/CSExitPenalties.go 0.00% 372 Missing ⚠️
cmd/lido-exporter/metrics/penalties.go 0.00% 20 Missing ⚠️
...nternal/lido/contracts/csfeedistributor/rewards.go 42.85% 19 Missing and 1 partial ⚠️
internal/ui/prompter.go 0.00% 10 Missing ⚠️
cli/cli.go 80.00% 6 Missing ⚠️
internal/pkg/commands/cmd_runner_helper_unix.go 33.33% 6 Missing ⚠️
cmd/lido-exporter/metrics/metrics.go 0.00% 3 Missing ⚠️
internal/pkg/clients/utils.go 0.00% 2 Missing ⚠️
cli/generate.go 50.00% 1 Missing ⚠️
internal/pkg/dependencies/dependencies.go 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #526      +/-   ##
===========================================
- Coverage    24.84%   24.13%   -0.71%     
===========================================
  Files          120      121       +1     
  Lines        22329    19672    -2657     
===========================================
- Hits          5547     4748     -799     
+ Misses       16237    14380    -1857     
+ Partials       545      544       -1     
Flag Coverage Δ
unittests 24.13% <10.46%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

configs.NetworkHoodi: "0x8664d394C2B3278F26A1B44B967aEf99707eeAB2",
},
CSExitPenalties: {
configs.NetworkMainnet: "0x06cd61045f958A209a0f8D746e103eCc625f4193",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need CSExitPenalties for Hoodi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khalifaa55 khalifaa55 marked this pull request as ready for review October 24, 2025 11:31
@stdevMac stdevMac merged commit c35cd60 into develop Oct 24, 2025
11 of 12 checks passed
@stdevMac stdevMac deleted the feat/lido-csm-v2 branch October 24, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants