Skip to content

Fix show command error when using containers tags #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AntiD2ta merged 5 commits into from
Jul 24, 2023
Merged

Fix show command error when using containers tags #300

AntiD2ta merged 5 commits into from
Jul 24, 2023

Conversation

@cbermudez97
Copy link
Contributor

@cbermudez97 cbermudez97 commented Jul 10, 2023

Changes:

  • Fix show command error when using containers tag

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.01 🎉

Comparison is base (0817aff) 86.69% compared to head (13375f7) 86.70%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #300      +/-   ##
===========================================
+ Coverage    86.69%   86.70%   +0.01%     
===========================================
  Files           78       78              
  Lines         4578     4582       +4     
===========================================
+ Hits          3969     3973       +4     
  Misses         523      523              
  Partials        86       86
Flag Coverage Δ
unittests 86.70% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/actions/getContainers.go 78.18% <83.33%> (+1.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

AntiD2ta
AntiD2ta approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@AntiD2ta AntiD2ta merged commit caf64a3 into develop Jul 24, 2023
@AntiD2ta AntiD2ta deleted the fix/show-tags-error branch July 24, 2023 13:18
stdevMac added a commit that referenced this pull request Jul 24, 2023
@cbermudez97 @stdevMac
fix: Show command error when using containers tags (#300)
0a73e07 
* test: add new show command test case

* fix: show command error when using containers tag

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>
AntiD2ta added a commit that referenced this pull request Jul 24, 2023
@stdevMac @dependabot
@cbermudez97 @AntiD2ta
Release v1.2.2 (#306)
e585a03 
* chore(deps): bump semver from 5.7.1 to 5.7.2 in /docs

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update image versions to latest version.

* fix: Show command error when using containers tags (#300)

* test: add new show command test case

* fix: show command error when using containers tag

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>

* Fix Chiado checkpoint sync (#298)

* fix: chiado env templates

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>

* [docs] Update documentation and Changelog

* [docs] Update documentation and Changelog

* [fix] typo on doc

* [fix] typo on doc

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stdevMac <stdevMac@users.noreply.github.com>
Co-authored-by: Carlos Bermudez Porto <43155355+cbermudez97@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>
stdevMac added a commit that referenced this pull request Aug 10, 2023
@stdevMac @AntiD2ta
@dependabot @cbermudez97
Rename xdai to gnosis (#308)
c5f729a 
* doc: Update sedge version in complete-guide.mdx

* doc: Update 1.2.0 to 1.2.1

* doc: Update CHANGELOG

* Release v1.2.2 (#306)

* chore(deps): bump semver from 5.7.1 to 5.7.2 in /docs

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update image versions to latest version.

* fix: Show command error when using containers tags (#300)

* test: add new show command test case

* fix: show command error when using containers tag

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>

* Fix Chiado checkpoint sync (#298)

* fix: chiado env templates

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>

* [docs] Update documentation and Changelog

* [docs] Update documentation and Changelog

* [fix] typo on doc

* [fix] typo on doc

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stdevMac <stdevMac@users.noreply.github.com>
Co-authored-by: Carlos Bermudez Porto <43155355+cbermudez97@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>

* [patch] rename xDai to gnosis

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>
Co-authored-by: AntiD2ta <mtpotro41@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stdevMac <stdevMac@users.noreply.github.com>
Co-authored-by: Carlos Bermudez Porto <43155355+cbermudez97@users.noreply.github.com>
AntiD2ta added a commit that referenced this pull request Aug 16, 2023
@stdevMac @dependabot
@cbermudez97 @AntiD2ta @nethermind-machine
Release v1.2.3 (#310)
416c803 
* chore(deps): bump semver from 5.7.1 to 5.7.2 in /docs

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update image versions to latest version.

* fix: Show command error when using containers tags (#300)

* test: add new show command test case

* fix: show command error when using containers tag

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>

* Fix Chiado checkpoint sync (#298)

* fix: chiado env templates

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>

* Support Erigon in Gnosis (#299)

* feat: add erigon to gnosis templates

* fix: broken tests

* fix: specific gnosis network tests checks

* fix: gnosis network tests checks

* fix: wrong network in test case

* Rename xdai to gnosis (#308)

* doc: Update sedge version in complete-guide.mdx

* doc: Update 1.2.0 to 1.2.1

* doc: Update CHANGELOG

* Release v1.2.2 (#306)

* chore(deps): bump semver from 5.7.1 to 5.7.2 in /docs

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update image versions to latest version.

* fix: Show command error when using containers tags (#300)

* test: add new show command test case

* fix: show command error when using containers tag

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>

* Fix Chiado checkpoint sync (#298)

* fix: chiado env templates

* chore: update changelog

---------

Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>

* [docs] Update documentation and Changelog

* [docs] Update documentation and Changelog

* [fix] typo on doc

* [fix] typo on doc

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stdevMac <stdevMac@users.noreply.github.com>
Co-authored-by: Carlos Bermudez Porto <43155355+cbermudez97@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>

* [patch] rename xDai to gnosis

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>
Co-authored-by: AntiD2ta <mtpotro41@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stdevMac <stdevMac@users.noreply.github.com>
Co-authored-by: Carlos Bermudez Porto <43155355+cbermudez97@users.noreply.github.com>

* [doc] update readme

* [doc] update documentation

* Update image versions to latest version. (#309)

Co-authored-by: stdevMac <stdevMac@users.noreply.github.com>

* [docs] Update changelog

* [docs] update Changelog

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stdevMac <stdevMac@users.noreply.github.com>
Co-authored-by: Carlos Bermudez Porto <43155355+cbermudez97@users.noreply.github.com>
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>
Co-authored-by: AntiD2ta <mtpotro41@gmail.com>
Co-authored-by: nethermind-machine <76107542+nethermind-machine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdevMac stdevMac stdevMac approved these changes

@AntiD2ta AntiD2ta AntiD2ta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cbermudez97 @codecov-commenter @stdevMac @AntiD2ta