Skip to content

Conversation

@cbermudez97
Copy link
Contributor

Changes:

  • Allow Sedge to load latest supported clients versions when online.
  • Add new flag to reuse jwt secret when regenerating a Sedge setup.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@cbermudez97 cbermudez97 self-assigned this Jun 8, 2023
@cbermudez97 cbermudez97 requested review from AntiD2ta, adriantpaez and stdevMac and removed request for AntiD2ta June 8, 2023 20:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

❌ Patch coverage is 45.51282% with 170 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.02%. Comparing base (847e2b9) to head (1714a0c).
⚠️ Report is 154 commits behind head on develop.

Files with missing lines Patch % Lines
configs/images/utils.go 25.53% 70 Missing ⚠️
configs/images/online_images.go 0.00% 54 Missing ⚠️
cli/actions/update_clients.go 0.00% 41 Missing ⚠️
cli/generate.go 60.00% 3 Missing and 1 partial ⚠️
cli/actions/actions.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #292      +/-   ##
===========================================
- Coverage    86.69%   84.02%   -2.68%     
===========================================
  Files           78       82       +4     
  Lines         4578     4833     +255     
===========================================
+ Hits          3969     4061      +92     
- Misses         523      686     +163     
  Partials        86       86              
Flag Coverage Δ
unittests 84.02% <45.51%> (-2.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants