Implement EIP-7805 (FOCIL) #8003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
Jun 5, 2025
Comment on lines
33
to
34
| TrieStore trieStore = TestTrieStoreFactory.Build(stateDb, LimboLogs.Instance); | ||
| _stateProvider = new WorldState(trieStore, new MemDb(), LimboLogs.Instance); |
There was a problem hiding this comment.
Not sure if needs update after: #8724
| } | ||
|
|
||
| block.InclusionListTransactions = suggestedBlock.InclusionListTransactions; | ||
| return _inclusionListValidator.ValidateInclusionList(block, _blockTransactionsExecutor.IsTransactionInBlock); |
There was a problem hiding this comment.
I think we don't need IsTransactionInBlock in executor and can simply check against block.Transactions?
| } | ||
| } | ||
|
|
||
| public void RecoverData(Transaction[] txs, IReleaseSpec releaseSpec, bool checkFirst) |
There was a problem hiding this comment.
why do we need different checkFirst mechanic?
| /// <c>true</c> if the block's inclusion list is satisfied according to EIP-7805; | ||
| /// otherwise, <c>false</c>. | ||
| /// </returns> | ||
| bool ValidateInclusionList(Block block, Func<Transaction, bool> isTransactionInBlock); |
There was a problem hiding this comment.
Why do you need to pass isTransactionInBlock? You should be able to check against block.Transactions
Comment on lines
+154
to
+162
| public void ForceRebuildPayload(string payloadId) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| public BlockHeader? GetPayloadHeader(string payloadId) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } |
There was a problem hiding this comment.
maybe interface segregation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
engine_getInclusionListPayloadAttributesandnewPayloadparametersTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes