Skip updating prewarm caches on main thread #7203
Conversation
|
Does it improve anything? Potentially very small chance of waiting on dictionary? Otherwise, it complicates the code and I don't like it. |
TryGet doesn't use any locks; GetOrAdd does TryGet, then if that fails TryAdd which aquires lock (potentially contending with prewarm) and allocates memory. However the MainProcessor will never read that value from the prewam cache ever again, so why do the extra work? |
src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs
Outdated
Show resolved
Hide resolved
benaadams
force-pushed
the
prewarm-main-thread
branch
from
6bd6f4e
to
f159c79
Compare
benaadams
force-pushed
the
prewarm-main-thread
branch
from
f159c79
to
b219c7e
Compare
| _transientStorageProvider = new TransientStorageProvider(logManager); | ||
| } | ||
|
|
||
| public WorldState(ITrieStore trieStore, IKeyValueStore? codeDb, ILogManager? logManager, PreBlockCaches? preBlockCaches) | ||
| : this(trieStore, codeDb, logManager, null, preBlockCaches: preBlockCaches) | ||
| public WorldState(ITrieStore trieStore, IKeyValueStore? codeDb, ILogManager? logManager, PreBlockCaches? preBlockCaches, bool populatePreBlockCache = true) |
There was a problem hiding this comment.
wonder if it would be better to make it false as default and explicitly set true, but not sure
There was a problem hiding this comment.
Too many locations; unless invert the meaning of the param.
Is only really really true if it also has the preBlockCaches not being null
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing