Skip prewarming tx if main processing has caught up #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
Jun 6, 2024
| @@ -113,6 +113,8 @@ public Transaction[] Transactions | |||
|
|
|||
| [JsonIgnore] | |||
| public ArrayPoolList<AddressAsKey>? AccountChanges { get; set; } | |||
| [JsonIgnore] | |||
| internal volatile int TransactionProcessed; | |||
There was a problem hiding this comment.
Can we pass it in different way? Block should be more of domain object.
Similar problem is with AccountChanges.
There was a problem hiding this comment.
Is a bit messy because of where the compents surface where currently the only shared comms is the block.
Will think about if it can be improved though
There was a problem hiding this comment.
lets introduce some sharable block processing context
LukaszRozmej
approved these changes
Jun 6, 2024
kamilchodola
pushed a commit
that referenced
this pull request
Jun 6, 2024
flcl42
added a commit
that referenced
this pull request
Jun 10, 2024
flcl42
added a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing