Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Git commit hash handling #7131

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Revise Git commit hash handling #7131

merged 2 commits into from
Jun 3, 2024

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jun 3, 2024

Changes

  • Removed dependency on Git executable in project files
  • Added Microsoft.Build.Tasks.Git package to incorporate the commit hash into the version string
  • Stopped copying the .git directory to Docker containers, which significantly increases local Docker image build times
  • Revised ClientVersionV1 tests
  • Removed the branch name check from the project file so as not to fail the build because of an undesired branch name. This logic is completely unrelated to the build process and must be handled at the GitHub level

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

@rubo rubo changed the title Revise git commit hash handling Revise Git commit hash handling Jun 3, 2024
@rubo rubo marked this pull request as ready for review June 3, 2024 15:20
@rubo rubo requested a review from a team as a code owner June 3, 2024 15:20
@rubo rubo merged commit 7cde3ec into master Jun 3, 2024
69 checks passed
@rubo rubo deleted the feature/version-commit branch June 3, 2024 16:41
@michaelsproul
Copy link

Was Nethermind returning a commit hash with length < 8 prior to this change? We are getting errors connecting LH to Nethermind v1.26:

Jun 06 03:04:48.001 WARN Execution engine call failed error: InvalidClientVersion("Input must be exactly 8 characters long (excluding any '0x' prefix)"), service: exec

@smartprogrammer93
Copy link
Contributor

@michaelsproul it used to return longer than 8:
#7013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants