Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pruning with LruCaheLowObject #7114

Merged
merged 8 commits into from
May 31, 2024
Merged

Fix pruning with LruCaheLowObject #7114

merged 8 commits into from
May 31, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented May 31, 2024 •
edited
Loading

Changes

  • Improve type conversions
  • Use DisableWAL when pruning old entries (will never be read again)
  • Increase pruning ConcurrentDictionary key set
  • Batch deletes into smaller chunks (256 rather than 250k)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • Optimization

Testing

Requires testing

  • No

Base automatically changed from fix/active-pruning-regression to master May 31, 2024 00:58
LukaszRozmej
LukaszRozmej approved these changes May 31, 2024
View reviewed changes
src/Nethermind/Nethermind.Db.Rocks/Config/DbConfig.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Trie/Pruning/TrieStore.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Trie/Pruning/TrieStore.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Trie/Pruning/TrieStore.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Trie/Pruning/TrieStore.cs Outdated Show resolved Hide resolved
@benaadams benaadams merged commit 33015b7 into master May 31, 2024
68 checks passed
@benaadams benaadams deleted the lrucache branch May 31, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @LukaszRozmej @asdacap