Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use dpkg instead uname to get unified arch in postinst debian script #6991

Merged
merged 1 commit into from
May 7, 2024

Conversation

kayano
Copy link
Contributor

@kayano kayano commented May 7, 2024

It seems uname changed what it returns doing uname -m.
I'm getting aarch64 running uname -m which results in wrong binary being installed when using nethermind ppa on arm64 machine.

Changes

  • use dpkg instead uname in ppa postinst debian script

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Ubuntu packaging

Testing

Requires testing

  • Yes
  • No

@kayano kayano requested review from rubo and a team as code owners May 7, 2024 21:50
@rubo
Copy link
Contributor

rubo commented May 7, 2024

What OS does return aarch instead of arm?

@kayano
Copy link
Contributor Author

kayano commented May 7, 2024

What OS does return aarch instead of arm?

lsb_release -a

No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.4 LTS
Release:	22.04
Codename:	jammy

uname -a
Linux  6.5.0-1018-aws #18~22.04.1-Ubuntu SMP Fri Apr  5 17:56:39 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

@rubo
Copy link
Contributor

rubo commented May 7, 2024

Good catch. We'll improve the script further to check the architectures explicitly and exit if not supported instead of falling back to the wrong one. Thank you for your contribution.

@rubo rubo merged commit 774b103 into NethermindEth:master May 7, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants