Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too eager dispose in js block tracing #6987

Merged
merged 1 commit into from
May 7, 2024

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented May 7, 2024

Changes

  • Makes engine dispose lazy on serialization, fixing the issue it was disposed too eagerly introduced in Javascript Tracer resource leak #6929
  • Disposes engines on exception
  • Removes ArrayPool as it is hard to dispose it just in the right time

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

@natebeauregard can you test it?

@natebeauregard
Copy link
Contributor

@LukaszRozmej Changes look good, I'll test this later today while gathering the performance numbers to ensure that everything is working ok and will approve then

Copy link
Contributor

@natebeauregard natebeauregard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing looked good, all of the JS tracers can be executed from the JSON-RPC endpoint. LGTM

@LukaszRozmej LukaszRozmej merged commit 7b161e6 into master May 7, 2024
67 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/js-tracers-too-eager-dispose branch May 7, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants