Traverse trie branches in same stack frame #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
reviewed
May 5, 2024
| [StackTraceHidden] | ||
| static ref readonly CappedArray<byte> TraverseBranch(TrieNode node) | ||
| { | ||
| throw new InvalidOperationException($"Branch node {node.Keccak} should already be handled"); |
There was a problem hiding this comment.
I think its possible that it traverse from branch to extension then back to branch.
There was a problem hiding this comment.
Have tenary inside TraverseExtension that calls TraverseBranches direcly so should be ok.
There was a problem hiding this comment.
For Extension
Before
After
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
HealingTrieStoreandScopedTrieStoreBefore
After
Also Before (showing how deep it goes)
Types of changes
What types of changes does your code introduce?
Testing
Requires testing