EIP-2537 #6964
Merged
EIP-2537 #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
May 1, 2024
|
|
||
| internal static BigInteger Normalise(in BigInteger x) | ||
| { | ||
| BigInteger unnormalised = x % BlsBaseFieldOrder; |
There was a problem hiding this comment.
BigIntegers are painfully slow, do we need simple UInt512 types?
There was a problem hiding this comment.
At some point the subgroup checks should be implemented in the cryptography library, so probably not worth optimising for now. Just implemented them in C# quickly for the devnet, and because we still might change libraries
MarekM25
reviewed
May 2, 2024
src/tests
Outdated
There was a problem hiding this comment.
we can revert it now as we're passing all tests, the EIP2537 tests have to be added to the develop in EthereumTests repo
MarekM25
reviewed
May 2, 2024
This was already implemented actually, just had to enable it for Prague |
Marchhill
commented
May 3, 2024
| @@ -192,7 +192,7 @@ private static void UpdateMetrics(ExecutionOptions opts, UInt256 effectiveGasPri | |||
| Metrics.BlockMaxGasPrice = Math.Max(gasPrice, Metrics.BlockMaxGasPrice); | |||
|
|
|||
| Metrics.AveGasPrice = (Metrics.AveGasPrice * Metrics.Transactions + gasPrice) / (Metrics.Transactions + 1); | |||
| Metrics.EstMedianGasPrice += Metrics.AveGasPrice * 0.01f * float.Sign(gasPrice - Metrics.EstMedianGasPrice); | |||
| Metrics.EstMedianGasPrice += Metrics.AveGasPrice * 0.01f * float.Sign(gasPrice - Metrics.AveGasPrice); | |||
There was a problem hiding this comment.
Had to do this to get the tests to pass, not sure if it is correct
MarekM25
approved these changes
May 7, 2024
LukaszRozmej
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes