Fix JsonRPc Double dispose

[obasekiosa]

Changes

• Removes unnecessary arraypoollist dispose

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Documentation

Requires documentation update

• Yes
• No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

• Yes
• No

If yes, fill in the details here. Remove if not applicable.

Remarks

maybe Add a property on ArrayPoolList call isDiposed to check if object has been disposed.
useful for nested arrayPoolLists.

Since we usually want to dispose the entire collection from the top
and sometimes we dispose inner collection from somewhere else when they are passed as references.

[LukaszRozmej]

Dispose should be able to be called multiple times.
This looks like a proper place to dispose it in JSON RPC stack - after serialization. Where is the 2nd conflicting dispose happen?

[LukaszRozmej]

Ok its disposed just above, so its fine, but added also safe dispose recursive

[obasekiosa]

Dispose should be able to be called multiple times. This looks like a proper place to dispose it in JSON RPC stack - after serialisation. Where is the 2nd conflicting dispose happen?

True!
Calling dispose multiple times should in theory work.

the problem comes when attempting to access an arraypoollist that has been disposed.

Theres a guard that throws an error. For example accessing Count for the purpose of looping through a list to dispose its content.