Fix/6790 return accepted for rejected tx added to broadcast

src/Nethermind/Nethermind.TxPool/TxBroadcaster.cs

@@ -97,31 +97,35 @@ public TxBroadcaster(IComparer<Transaction> comparer,
         // only for testing reasons
         internal Transaction[] GetSnapshot() => _persistentTxs.GetSnapshot();
 
-        public void Broadcast(Transaction tx, bool isPersistent)
+        public bool Broadcast(Transaction tx, bool isPersistent)
         {
             if (isPersistent)
             {
-                StartBroadcast(tx);
-            }
-            else
-            {
-                BroadcastOnce(tx);
+                return StartBroadcast(tx);
             }
+
+            BroadcastOnce(tx);
+
+            return true;
         }
 
-        private void StartBroadcast(Transaction tx)
+        private bool StartBroadcast(Transaction tx)
         {
+            if (tx is null) return false;
+
+            bool txInserted = _persistentTxs.TryInsert(tx.Hash, tx.SupportsBlobs ? new LightTransaction(tx) : tx);
+
+            if (!txInserted) return false;
+
             // broadcast local tx only if MaxFeePerGas is not lower than configurable percent of current base fee
             // (70% by default). Otherwise only add to persistent txs and broadcast when tx will be ready for inclusion
             if (tx.MaxFeePerGas >= _baseFeeThreshold || tx.IsFree())
             {
                 NotifyPeersAboutLocalTx(tx);
+                return true;
             }
 
-            if (tx.Hash is not null)
-            {
-                _persistentTxs.TryInsert(tx.Hash, tx.SupportsBlobs ? new LightTransaction(tx) : tx);
-            }
+            return false;
         }
 
         private void BroadcastOnce(Transaction tx)

src/Nethermind/Nethermind.TxPool/TxPool.cs

@@ -450,14 +450,15 @@ private AcceptTxResult AddCore(Transaction tx, TxFilteringState state, bool isPe
             if (tx.Hash == removed?.Hash)
             {
                 // it means it was added and immediately evicted - pool was full of better txs
-                if (isPersistentBroadcast)
+                if (!isPersistentBroadcast || tx.SupportsBlobs || !_broadcaster.Broadcast(tx, true))
                 {
                     // we are adding only to persistent broadcast - not good enough for standard pool,
                     // but can be good enough for TxBroadcaster pool - for local txs only
-                    _broadcaster.Broadcast(tx, isPersistentBroadcast);
+                    Metrics.PendingTransactionsPassedFiltersButCannotCompeteOnFees++;
+                    return AcceptTxResult.FeeTooLowToCompete;
+                } else {
+                    return AcceptTxResult.Accepted;
                 }
-                Metrics.PendingTransactionsPassedFiltersButCannotCompeteOnFees++;
-                return AcceptTxResult.FeeTooLowToCompete;
             }
 
             relevantPool.UpdateGroup(tx.SenderAddress!, state.SenderAccount, UpdateBucketWithAddedTransaction);