Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FCU params handling order and return codes #6870

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Update FCU params handling order and return codes #6870

merged 7 commits into from
Apr 4, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Mar 27, 2024

Fixes #6677

Changes

  • Update FCU error codes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 marked this pull request as ready for review March 29, 2024 10:14
@flcl42 flcl42 requested a review from LukaszRozmej April 1, 2024 08:10
@flcl42 flcl42 merged commit c2529a9 into master Apr 4, 2024
67 checks passed
@flcl42 flcl42 deleted the update-handling-fcu-payload-attributes branch April 4, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@deffrian deffrian Awaiting requested review from deffrian

@marcindsobczak marcindsobczak Awaiting requested review from marcindsobczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining Hive Cancun Test Failures
4 participants
@flcl42 @benaadams @LukaszRozmej @smartprogrammer93