Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring last state to be kept #6809

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Mar 4, 2024

  • Snap protocol requires that the last 128 state be available.
  • This is also useful for eth_call RPC where user may want a certain window of state to be available.
  • This create a new state layout agnostic config --State.KeepLastNState 64 so that this window can be configured.
    • No, I don't like the name too, give me a good one.

Changes

  • Add config.
  • Integrate with TrieStore.

Types of changes

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Can snap serve from old state. (client hooked up to use pivot head-70 instead of head).
  • Snap hive test (its running on archive, so has no effect).

@asdacap asdacap mentioned this pull request Mar 19, 2024
8 tasks
@asdacap asdacap merged commit d39f00e into master Mar 20, 2024
67 checks passed
@asdacap asdacap deleted the feature/configurable-state-reorg-depth branch March 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants