TxPool autorecover #6789
Merged
TxPool autorecover #6789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
reviewed
Feb 28, 2024
|
|
||
| var pool = new WithFinalizerDistinctPool(Capacity, comparer, new WithFinalizerComparer(), LimboLogs.Instance); | ||
| [Test] | ||
| public void Capacity_is_never_exceeded() |
There was a problem hiding this comment.
Should this run in parallel or should their be a Parallel varient of it? (Since txPool is running concurrently with adds)
There was a problem hiding this comment.
there is Capacity_is_never_exceeded_with_multiple_threads
and I've just refactored Capacity_is_never_exceeded
benaadams
approved these changes
Feb 28, 2024
jmederosalvarado
added a commit
that referenced
this pull request
Mar 18, 2024
This reverts commit 84ff7e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TxPool autorecovering if it exceeded capacity
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
For now I am experimenting
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.