Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update txPool worst value if removal unsuccessful #6702

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

benaadams
Copy link
Member

Resolves #6557

Changes

  • If txPool fails to remove txn due to an out of date worst value; update then remove again

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • No

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please wait for @marcindsobczak review too.

Copy link
Contributor

@marcindsobczak marcindsobczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benaadams benaadams merged commit f262cb2 into master Feb 12, 2024
67 checks passed
@benaadams benaadams deleted the txPool-worst-value branch February 12, 2024 09:50
kamilchodola added a commit that referenced this pull request Feb 16, 2024
* Resolved conflicts

* max body size for http json rpc (#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (#6672)

* Update txPool worst value if removal unsuccessful (#6702)

* Add Cancun hard-fork settings for Gnosis (#6709)

* Cancun spec and config for mainnet (#6679)

* Add Paris release spec class for completeness (#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
kamilchodola added a commit that referenced this pull request Feb 23, 2024
* Resolved conflicts

* max body size for http json rpc (#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (#6672)

* Update txPool worst value if removal unsuccessful (#6702)

* Add Cancun hard-fork settings for Gnosis (#6709)

* Cancun spec and config for mainnet (#6679)

* Add Paris release spec class for completeness (#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
kamilchodola added a commit that referenced this pull request Feb 26, 2024
* Resolved conflicts

* max body size for http json rpc (#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (#6672)

* Update txPool worst value if removal unsuccessful (#6702)

* Add Cancun hard-fork settings for Gnosis (#6709)

* Cancun spec and config for mainnet (#6679)

* Add Paris release spec class for completeness (#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
gr8h pushed a commit to fuseio/nethermind-client that referenced this pull request Jun 25, 2024
* Resolved conflicts

* max body size for http json rpc (NethermindEth#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (NethermindEth#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (NethermindEth#6672)

* Update txPool worst value if removal unsuccessful (NethermindEth#6702)

* Add Cancun hard-fork settings for Gnosis (NethermindEth#6709)

* Cancun spec and config for mainnet (NethermindEth#6679)

* Add Paris release spec class for completeness (NethermindEth#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
gr8h pushed a commit to fuseio/nethermind-client that referenced this pull request Jun 25, 2024
* Resolved conflicts

* max body size for http json rpc (NethermindEth#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (NethermindEth#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (NethermindEth#6672)

* Update txPool worst value if removal unsuccessful (NethermindEth#6702)

* Add Cancun hard-fork settings for Gnosis (NethermindEth#6709)

* Cancun spec and config for mainnet (NethermindEth#6679)

* Add Paris release spec class for completeness (NethermindEth#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
gr8h pushed a commit to fuseio/nethermind-client that referenced this pull request Jun 25, 2024
* Resolved conflicts

* max body size for http json rpc (NethermindEth#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (NethermindEth#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (NethermindEth#6672)

* Update txPool worst value if removal unsuccessful (NethermindEth#6702)

* Add Cancun hard-fork settings for Gnosis (NethermindEth#6709)

* Cancun spec and config for mainnet (NethermindEth#6679)

* Add Paris release spec class for completeness (NethermindEth#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob pool exceeds the config size 17175/16384
3 participants