Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse BlockParameter correctly for eth_call #6477

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Parse BlockParameter correctly for eth_call #6477

merged 1 commit into from
Jan 8, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Should parse blockHash when requireCanonical is not present

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams merged commit 440a173 into master Jan 8, 2024
67 checks passed
@benaadams benaadams deleted the BlockParameter branch January 8, 2024 13:35
kamilchodola pushed a commit that referenced this pull request Jan 8, 2024
@benaadams @kamilchodola
Parse BlockParameter correctly for eth_call (#6477)
14cc9d8
@benaadams benaadams added the bug label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubo rubo rubo approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @rubo @LukaszRozmej