-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/request receipts #6413
Bugfix/request receipts #6413
Conversation
src/Nethermind/Nethermind.Merge.Plugin/Synchronization/MergeBlockDownloader.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Synchronization/MergeBlockDownloader.cs
Outdated
Show resolved
Hide resolved
c298709
to
198309e
Compare
4d9bcfe
to
d45dc09
Compare
d45dc09
to
6cf58f9
Compare
Resolves Hive Sync after 2 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts (Paris) (nethermind) This one still outstanding though Sync after 128 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts (Paris) (nethermind) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain logic behind this changes?
src/Nethermind/Nethermind.Merge.Plugin/Synchronization/MergeBlockDownloader.cs
Outdated
Show resolved
Hide resolved
Just an idera, why not make fast and full use the same downloader so that we don't have to guess which part start from which block at which thread. |
So you need to involve state sync too I guess, because it defines the moment when we switch from fast sync(bodies and receipts) to full sync(bodies and processing). |
src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloadContext.cs
Outdated
Show resolved
Hide resolved
? |
@kamilchodola run smoke tests on this PR before merging |
Sync after 2 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts (nethermind) 🟢 fixed https://github.com/NethermindEth/nethermind/actions/runs/8156727376/job/22294826941 |
Fixes #5904
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?