Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/request receipts #6413

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Bugfix/request receipts #6413

merged 8 commits into from
Mar 6, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Dec 22, 2023

Fixes #5904

Changes

  • Load receipts in case of fast sync transition
  • Set state block number to recently processed block number

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 marked this pull request as ready for review January 17, 2024 13:32
@benaadams
Copy link
Member

@benaadams
Copy link
Member

Resolves Hive

Sync after 2 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts (Paris) (nethermind)

This one still outstanding though

Sync after 128 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts (Paris) (nethermind)

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain logic behind this changes?

@asdacap
Copy link
Contributor

asdacap commented Feb 14, 2024

Just an idera, why not make fast and full use the same downloader so that we don't have to guess which part start from which block at which thread.

@flcl42
Copy link
Contributor Author

flcl42 commented Feb 21, 2024

Just an idera, why not make fast and full use the same downloader so that we don't have to guess which part start from which block at which thread.

So you need to involve state sync too I guess, because it defines the moment when we switch from fast sync(bodies and receipts) to full sync(bodies and processing).

@LukaszRozmej
Copy link
Member

Can you explain logic behind this changes?

?

@smartprogrammer93
Copy link
Contributor

@kamilchodola run smoke tests on this PR before merging

@marcindsobczak
Copy link
Contributor

Sync after 2 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts (nethermind) 🟢 fixed
Sync after 128 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts (nethermind) 🔴 still failing

https://github.com/NethermindEth/nethermind/actions/runs/8156727376/job/22294826941

@flcl42 flcl42 merged commit 018b8ae into master Mar 6, 2024
73 of 79 checks passed
@flcl42 flcl42 deleted the bugfix/request-receipts branch March 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate regression in hive tests - two failing tests for Multiple Withdrawal Accounts
7 participants