Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kiln testnet configs #5181

Merged
merged 4 commits into from
Jan 21, 2023
Merged

Conversation

Zachinquarantine
Copy link
Contributor

Changes

Removes remaining configs for the deprecated "Kiln" testnet.

Types of changes

Removes JSON configs and various other configs.

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or a feature that would cause existing functionality not to work as expected)
  • Documentation update
  • Code style update (formatting, renaming)
  • Refactoring (no functional or API changes)
  • Build-related changes
  • Other: description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't removed it because it was used by Lodestar team in their CI. Let me confirm if they're still using it

@rubo
Copy link
Contributor

rubo commented Jan 21, 2023

@dapplion Do you guys still need this?

@Zachinquarantine In case of removal, could you please remove src/Nethermind/Chains/themerge_kiln_testvectors.json as well?

@dapplion
Copy link
Contributor

dapplion commented Jan 21, 2023

CC: @g11tech, he built that CI you mention on Lodestar

@g11tech
Copy link

g11tech commented Jan 21, 2023

CC: @g11tech, he built that CI you mention on Lodestar

I don't think we use kiln configs but i will check and update what we use

@MarekM25
Copy link
Contributor

Yes, I confirmed it with @g11tech before. Thx @Zachinquarantine for your PR :)

@MarekM25 MarekM25 merged commit 415aaef into NethermindEth:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants