Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next header hash may be misset on resume. #5112

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jan 9, 2023

  • Seems like it does not reinitialize to the right header. This might cause the sync to hang as it failed validation, which also trigger a disconnect. Seen on sepolia, although it tend to recover on its own eventually.
  • Previously, this would only get triggered on restart.

Changes

  • Make sure on restart the fast header sync set the next expected header to parent of the lowest inserted header instead of the lowest inserted header.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Tested on sepolia

@asdacap asdacap merged commit 2c363ba into master Jan 9, 2023
@asdacap asdacap deleted the fix/fast-header-hangs-sometime branch January 9, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants