Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release approval handling #5097

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Fix release approval handling #5097

merged 3 commits into from
Jan 5, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jan 5, 2023

Changes

  • Fixed release approval handling in workflow
  • Optimized HTTP request handling
  • Optimized GitHub release creation

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or a feature that would cause existing functionality not to work as expected)
  • Documentation update
  • Code style update (formatting, renaming)
  • Refactoring (no functional or API changes)
  • Build-related changes
  • Other: description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@rubo rubo added the devops label Jan 5, 2023
@rubo rubo requested a review from kamilchodola January 5, 2023 00:50
@rubo rubo marked this pull request as ready for review January 5, 2023 01:02
@rubo rubo merged commit 095237f into master Jan 5, 2023
@rubo rubo deleted the hotfix/release-approval branch January 5, 2023 09:36
kamilchodola pushed a commit that referenced this pull request Jan 5, 2023
@rubo @kamilchodola
Fix release approval handling (#5097)
9e8b3da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchodola kamilchodola kamilchodola approved these changes

Assignees
No one assigned
Labels
devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubo @kamilchodola