Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If two peer have same speed, randomly try the other one. #5059

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 27, 2022

Fix #5014

  • It was observed in sepolia where during snap sync sometimes nethermind account request timed out on a peer. The peer got sleep as expected, it then try another peer, which also timed out, which then got sleep, then got allocated back to the first peer, then timeout again.
  • This should change the peer allocation to try other peer also if it has the same speed.

Changes:

  • Add a clause to randomly try other peer if it has the same speed.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@asdacap asdacap merged commit 2e350c3 into master Dec 27, 2022
@asdacap asdacap deleted the fix/sepolia-hang-on-snap branch December 27, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sepolia] 0% on SNAP Phase 1 for a long time because of bad peers
2 participants