Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp Based Fork Activation #4643

Merged
merged 43 commits into from
Oct 28, 2022
Merged

Timestamp Based Fork Activation #4643

merged 43 commits into from
Oct 28, 2022

Conversation

smartprogrammer93
Copy link
Contributor

Resolves #4605

Changes:

  • just adding timestamp to the equation when it comes to the spec provider

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@smartprogrammer93 smartprogrammer93 changed the title Timestamp Based Fork Activation Timestamp Based Fork Activation WIP Sep 26, 2022
@smartprogrammer93 smartprogrammer93 changed the title Timestamp Based Fork Activation WIP Timestamp Based Fork Activation Sep 26, 2022
@smartprogrammer93 smartprogrammer93 marked this pull request as ready for review September 26, 2022 16:06
LukaszRozmej
LukaszRozmej reviewed Sep 28, 2022
View reviewed changes
src/Nethermind/Nethermind.Blockchain/Spec/ChainHeadSpecProvider.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Core.Test/FixedBlockChainHeadSpecProvider.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Benchmark/MultipleUnsignedOperations.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/BlockProduction/PayloadPreparationService.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/HeaderDecoder.cs Show resolved Hide resolved
src/Nethermind/Nethermind.Specs.Test/CustomSpecProvider.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs.Test/OverridableSpecProvider.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainSpecBasedSpecProvider.cs Outdated Show resolved Hide resolved
LukaszRozmej
LukaszRozmej requested changes Oct 19, 2022
View reviewed changes
src/Nethermind/Ethereum.Test.Base/BlockchainTestBase.cs Outdated Show resolved Hide resolved
src/Nethermind/Ethereum.Test.Base/GeneralTestBase.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/Validators/BlockValidatorTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Test/Eip1344Tests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Test/Eip2028Tests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Test/VirtualMachineTestsBase.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc.Test/Modules/GasPriceOracleTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs.Test/CustomSpecProvider.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs.Test/CustomSpecProviderTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Core/Specs/ISpecProvider.cs Show resolved Hide resolved
MarekM25
MarekM25 reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments :)

MarekM25
MarekM25 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a final test, please run goerli/mainnet and veirfy if chainspec is loading correctly

@MarekM25 MarekM25 merged commit 03ee69c into master Oct 28, 2022
@MarekM25 MarekM25 deleted the TimestampBasedForkActivation branch October 28, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 MarekM25 approved these changes

@dceleda dceleda Awaiting requested review from dceleda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fork activation by timestamp
3 participants
@smartprogrammer93 @MarekM25 @LukaszRozmej