Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor persistent broadcast #3901

Merged
merged 11 commits into from
Mar 28, 2022
Merged

Conversation

marcindsobczak
Copy link
Contributor

@marcindsobczak marcindsobczak commented Mar 24, 2022

Changes:

  • prepare transactions to send from persistent broadcast only once per block instead once per block per every peer
  • broadcast only up to defined percent (PeerNotificationThreshold) of transactions from persistent broadcast instead of every transaction that meets the condition tx.MaxFeePerGas >= CurrentBaseFee
  • increased PeerNotificationThreshold to 5%

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 1437f48 into master Mar 28, 2022
@LukaszRozmej LukaszRozmej deleted the refactor/persistent_broadcast branch March 28, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants