Fix/wrong startup logic #3882
Merged
Fix/wrong startup logic #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Mar 16, 2022
Comment on lines
46
to
47
| if (_api.BlockProducer == null) throw new StepDependencyException(nameof(_api.BlockProducer)); | ||
| if (_api.BlockTree == null) throw new StepDependencyException(nameof(_api.BlockTree)); |
There was a problem hiding this comment.
Move those to StartBlockProducer
| if (consensusPlugin is not null) | ||
| { | ||
| foreach (IConsensusWrapperPlugin wrapperPlugin in _api.GetConsensusWrapperPlugins()) | ||
| if (_api.BlockProducer != null && _api.BlockTree != null) |
There was a problem hiding this comment.
Move StepDependencyExceptions here instead of this if
LukaszRozmej
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Resolves #3771.
Changes:
Divided StartBlockProducer into two classes.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing