Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Account Abstraction] Return RequestId instead of hash, Ban GAS opcode, update tests to work with latest entryPoint #3825

Merged
merged 22 commits into from
Feb 22, 2022
Merged

[Account Abstraction] Return RequestId instead of hash, Ban GAS opcode, update tests to work with latest entryPoint #3825

merged 22 commits into from
Feb 22, 2022

Conversation

kristofgazso
Copy link
Contributor

@kristofgazso kristofgazso commented Feb 15, 2022 •
edited by jorem321
Loading

Closes #3802

Changes:

  • In the title.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

jorem321 and others added 22 commits February 9, 2022 18:00
@jorem321
Added placeholder for new RequestId attribute. Started working on rew…
9a333b5 
…riting UserOperationDecoder
@kristofgazso
WIP
5c6ef2d
@jorem321
Working on fixing functions in UserOperation and writing a test for R…
58ec78a 
…equestId
@jorem321
Filled out request id test with goerli data
bd2b030
@jorem321
fixed various code typos
8f3e6ce
@kristofgazso
update abi encoding
3d90d82
@jorem321
killed most bugs
c9e308d
@jorem321
killed more bugs
836c182
@jorem321
all errors fixed, now testing
2dadda6
@kristofgazso
fixed abi encoding
15a83c7
@kristofgazso
getting closer
6fc1d53
@kristofgazso
more fixes
2b09bae
@kristofgazso
fixed more tests
cda2cb0
@kristofgazso
merge origin/master
5f58243
@kristofgazso
ban GAS
56ce369
@jorem321
Update SimpleWallet.json
e9b9716
@jorem321
Update TokenPaymaster.json
a7cf4ca
@kristofgazso
lots of fixes
216dfda
@jorem321
Verifying that requestid works regardless of signature.
3193050
@jorem321
New test showing potential signature problems
cc53960
@jorem321
Fix a bug in UserOperationBuilder that causes wrong signature computing.
503fd68
@kristofgazso
fixed tests
34fe17d
@kristofgazso kristofgazso changed the title Aa return requestid instead of hash [Account Abstraction] Return RequestId instead of hash, Ban GAS opcode, update tests to work with latest entryPoint Feb 17, 2022
@kristofgazso kristofgazso mentioned this pull request Feb 17, 2022
Merged
@kristofgazso kristofgazso marked this pull request as ready for review February 22, 2022 11:03
@kristofgazso kristofgazso merged commit f06b20f into master Feb 22, 2022
@kristofgazso kristofgazso deleted the aa_return_requestid_instead_of_hash branch February 22, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@jmederosalvarado jmederosalvarado Awaiting requested review from jmederosalvarado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kristofgazso @LukaszRozmej @jorem321