Eth call variants #3824
Closed
Eth call variants #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthModule.TransactionExecutor.cs
Comment on lines
+40
to
+43
| [ConfigItem( | ||
| Description = "Defines whether the eth_call should be executed without taking base fee into consideration (in case when maxPriorityFeePerGas and maxFeePerGas are equal to zero).", | ||
| DefaultValue = "false")] | ||
| bool NoBaseFee { get; set; } |
There was a problem hiding this comment.
shouldn't it be true by default?
| new CallTxExecutor(_blockchainBridge, _blockFinder, _rpcConfig) | ||
| public ResultWrapper<string> eth_call(TransactionForRpc transactionCall, BlockParameter? blockParameter = null) | ||
| { | ||
| _rpcConfig.NoBaseFee = true; |
There was a problem hiding this comment.
we are changing the config?
Comment on lines
159
to
167
| else | ||
| { | ||
| return transaction.GasPrice.IsZero; | ||
| } | ||
| } | ||
| else | ||
| { | ||
| return transaction.GasPrice.IsZero; | ||
| } |
| UInt256 value = transaction.Value; | ||
|
|
||
| if (!noBaseFee || transaction.MaxFeePerGas > 0 || transaction.MaxPriorityFeePerGas > 0) |
There was a problem hiding this comment.
meaningful labels for bool checks
| UInt256 senderBalance = _stateProvider.GetBalance(caller); | ||
| if (!noValidation && ((ulong)intrinsicGas * effectiveGasPrice + value > senderBalance || | ||
| senderReservedGasPayment + value > senderBalance)) | ||
| if (!noBaseFee || !skipGasPricing) |
There was a problem hiding this comment.
meaningful labels for bool checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #4948
Changes:
Support various eth_call invocations post-1559. More information can be found here: ethereum/go-ethereum#23027.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??