Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/eth subscription base fee per gas missing #3810

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Fix/eth subscription base fee per gas missing #3810

merged 7 commits into from
Feb 11, 2022

Conversation

kjazgar
Copy link
Contributor

@kjazgar kjazgar commented Feb 10, 2022 •
edited by dceleda
Loading

Resolves #3786

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

LukaszRozmej
LukaszRozmej requested changes Feb 11, 2022
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but API is suboptimal

src/Nethermind/Nethermind.JsonRpc/Modules/Subscribe/SubscriptionFactory.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Subscribe/SubscribeRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Subscribe/NewHeadSubscription.cs Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Subscribe/ISubscriptionManager.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Subscribe/ISubscriptionFactory.cs Outdated Show resolved Hide resolved
@LukaszRozmej LukaszRozmej merged commit 66d4268 into master Feb 11, 2022
@LukaszRozmej LukaszRozmej deleted the fix/eth_subscription_baseFeePerGas_missing branch February 11, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@dceleda dceleda Awaiting requested review from dceleda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blocks through newHeads subscription do not contain baseFeePerGas
2 participants
@kjazgar @LukaszRozmej