Fix/clique validation on initial sync #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adersSync in order to have full epoch and be able to validate snapshot.
LukaszRozmej
requested review from
tkstanczak,
MarekM25,
dceleda and
marcindsobczak
marcindsobczak
approved these changes
Jan 26, 2022
dceleda
approved these changes
Jan 26, 2022
dceleda
reviewed
Jan 26, 2022
| @@ -423,6 +433,7 @@ private bool ShouldBeInStateNodesMode(Snapshot best) | |||
| bool hasFastSyncBeenActive = best.Header >= PivotNumber; | |||
| bool hasAnyPostPivotPeer = AnyPostPivotPeerKnown(best.PeerBlock); | |||
| bool notInFastSync = !best.IsInFastSync; | |||
| bool notNeedToWaitForHeaders = NotNeedToWaitForHeaders; | |||
There was a problem hiding this comment.
Is it needed for the State Sync in ShouldBeInStateNodesMode ?
Why can't we start immediately ?
There was a problem hiding this comment.
we need to DL and validate Head header in order to know which state root to download
dceleda
approved these changes
Jan 26, 2022
…on_on_initial_sync # Conflicts: # src/Nethermind/Nethermind.Synchronization.Test/ParallelSync/MultiSyncModeSelectorTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
On Clique, makes header download prerequisite for further FastSync. This was an issue, where we Clique on FastSync couldn't validate blocks, because of missing Headers from last epoch.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
In case you checked yes, did you write tests??