Dns peer feed no queue #3716
Merged
Dns peer feed no queue #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with master node
… from the mock - also found one bug with session that was fixed by the changes
src/Nethermind/Nethermind.Network.Benchmark/NodeStatsCtorBenchmarks.cs
Outdated
Show resolved
Hide resolved
Comment on lines
90
to
92
| string broken = nodeRecordText[4..].Replace("-", "+").Replace("_", "/"); | ||
| broken = broken.PadRight(nodeRecordText.Length % 4); | ||
| RlpStream rlpStream = new(Convert.FromBase64String(broken)); |
There was a problem hiding this comment.
This looks weird, also string manipulation can prrobably in place char span manipulation
There was a problem hiding this comment.
impact on memory is minimal, measured it in dotmemory 16kb or so
There was a problem hiding this comment.
Is the PadRight doing what is expected here?
There was a problem hiding this comment.
Moved it to a bit better implementation with StringBuilder, still not sure about PadRight
There was a problem hiding this comment.
This needs tests to be added!
There was a problem hiding this comment.
Fixed a lot of things but EnrDiscoveryTests fails to parse 1/6th of enr's
src/Nethermind/Nethermind.Runner/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
Comment on lines
320
to
323
| // if (publicKeyOutput.Length < 64) | ||
| // { | ||
| // throw new ArgumentException($"{nameof(publicKeyOutput)} must be {64} bytes"); | ||
| // } |
Comment on lines
348
to
352
| // int expectedInputLength = flags == Secp256K1EcCompressed ? 33 : 64; | ||
| // if (publicKey.Length != expectedInputLength) | ||
| // { | ||
| // throw new ArgumentException($"{nameof(publicKey)} must be {expectedInputLength} bytes"); | ||
| // } |
# Conflicts: # src/Nethermind/Nethermind.Trie/TrieNode.cs
LukaszRozmej
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...