Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more subscription options #3686

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Conversation

kjazgar
Copy link
Contributor

@kjazgar kjazgar commented Dec 13, 2021

Fixes | Closes | Resolves #

Resolves #3455.

Changes:

Added includeTransactions option to eth_subscribe for new headers and pending transactions.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit b4d20c1 into master Dec 14, 2021
@LukaszRozmej LukaszRozmej deleted the add_more_subscription_options branch December 14, 2021 07:41
@LukaszRozmej
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more subscription options
2 participants