Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling for trace rpc module. #3604

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

kjazgar
Copy link
Contributor

@kjazgar kjazgar commented Nov 12, 2021

Fixes | Closes | Resolves #

Changes:

Improved error handling for TraceRpcModule when InsufficientBalanceException is thrown.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 77134c0 into master Nov 15, 2021
@LukaszRozmej LukaszRozmej deleted the InsufficientBalanceException_trace_fix branch November 15, 2021 08:32
@kjazgar kjazgar linked an issue Nov 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InsufficientBalanceException on eth_estimateGas
2 participants