build(zisk): bump Zisk to 1.1.0-alpha - #12910
Conversation
Update the guest build image to nethermindeth/zisk:1.1.0-alpha and raise Nethermind.ZiskOS.Runtime to 1.0.0-preview.7 so the managed runtime matches the new zkVM ABI. Signed-off-by: Maxim Menshikov <maksim.menshikov@nethermind.io>
|
Claude finished @maximmenshikov's task in 2m 45s —— View job Code review: ZisK toolchain bump to 1.1.0-alpha
Verdict: no Critical / High / Medium findings. This is a clean, minimal two-line toolchain bump. The blast radius is genuinely confined to the ZisK guest, and I verified that rather than assuming it. What I checked
Also worth noting: Low-severity notes
Not verifiedI could not confirm that Recommendation: approve and merge once |
EVM Opcode Benchmark DiffAggregated runs: base=3, pr=3 Regressions (1)
Improvements (1)
|
Point BFLAT_IMAGE at the acee0ec build so the guest is compiled against the ZisK 1.1.0-alpha ABI. The previous image was built against 1.0.0 and produced binaries using the now-deprecated dma_xmemcmp syscall. Signed-off-by: Maxim Menshikov <maksim.menshikov@nethermind.io>
|
Claude finished @maximmenshikov's task in 2m 27s —— View job Re-review: ZisK toolchain bump to 1.1.0-alpha
Verdict: no Critical / High / Medium findings. Mergeable. The one open item from my 23:42Z review — "approve and merge once What changed since my last reviewCommit Stateless execution tests: green, and it's real evidenceRun suffix=012500000001000000000000000c00000004000000080000000800000057b05d6900000000
grep -q "${{ matrix.output }}$suffix" "$RUNNER_TEMP/run.log"It greps for the expected state root plus a hardcoded trailing output-framing byte string. Nine passes against that literal establishes concretely that:
Both my earlier "not verified" caveats are now settled by CI rather than by inspection: the digest resolved (the pull would fail on a mismatched The one red check is unrelated
That dependency reaches into unexported Go runtime internals and broke against the runner's Go toolchain. Nethermind never started — the cascading Remaining Low (1)
Closed since last review
Other checks
Recommendation: approve and merge. The Hoodi sync red is pre-existing infra and should not gate this. |
Update the guest build image to nethermindeth/zisk:1.1.0-alpha and raise Nethermind.ZiskOS.Runtime to 1.0.0-preview.7 so the managed runtime matches the new zkVM ABI.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes