fix: normalize discovery bootnodes merge from chainspec #10063
Closed
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Was in `UpdateDiscoveryConfig` step. | ||
| if (discoveryConfig.Bootnodes != string.Empty) | ||
| if (!string.IsNullOrEmpty(discoveryConfig.Bootnodes)) |
Member
There was a problem hiding this comment.
How this could be null as it is string.Empty by default?
Member
|
it fails checks |
LukaszRozmej
reviewed
Jan 5, 2026
LukaszRozmej
reviewed
Jan 5, 2026
Member
|
Not worht it/meaningful in the end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscoveryConfig.Bootnodes could be null and was concatenated using '+=' with chainspec bootnodes, producing a leading comma in the final enode list. At the same time the code tried to guard against a null ChainSpec.Bootnodes array using 'is not null', even though the array is always initialized by the chainspec loader.
Normalized discovery bootnodes handling by treating null and empty as the same state using string.IsNullOrEmpty and by relying on ChainSpec.Bootnodes.Length != 0 instead of a misleading null check. As a result, the merged bootnodes string is well-formed and better matches the actual contracts of both configs.