fix: track deleted accounts across transactions for zombie recreation #10051
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkushinDaniil
requested review from
LukaszRozmej,
asdacap,
benaadams,
damian-orzechowski,
flcl42 and
tanishqjasoria
as code owners
LukaszRozmej
approved these changes
Dec 27, 2025
Comment on lines
+460
to
+468
| { | ||
| // Account was deleted earlier in this block | ||
| _needsStateRootUpdate = true; | ||
| if (_logger.IsTrace) TraceBlockLevel(address); | ||
|
|
||
| Account account = Account.TotallyEmpty; | ||
| StackList<int> stack = SetupCache(address); | ||
| PushRecreateEmpty(address, account, stack); | ||
| } |
Member
There was a problem hiding this comment.
This looks weird - like it belongs to the if but it does in fact is in else
asdacap
approved these changes
Dec 28, 2025
Contributor
asdacap
left a comment
asdacap
left a comment
There was a problem hiding this comment.
Are you sure you cant put this in plugin?
Member
It would be great to be in the plugin but we would have to expose |
Contributor
|
Can't this be done with a decorated |
Contributor
Tried this with the original change, but it wasn't possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
_deletedThisBlockHashSet to track accounts deleted during block processingCreateEmptyAccountIfDeletedOrNewto check block-level deletions for cross-transaction zombie account recreationResetBlockChangesTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Tested via Arbitrum plugin tests which compare state roots against Nitro reference implementation
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
Required for Arbitrum's pre-FixZombieAccounts behavior where zero-value transfers must recreate deleted accounts as empty "zombie" accounts. After the WorldState refactor,
CreateEmptyAccountIfDeletedOrNewcould only detect deletions within the same transaction's cache. This change enables detection of accounts deleted in earlier transactions within the same block.