feat(tools): add EthProofValidator #10026
Conversation
…ion with Rust-based ZK verifiers
ManuelArto
requested review from
LukaszRozmej,
MarekM25 and
rubo
as code owners
| // The following include Single-GPU (1:100) zk proofs | ||
| // var blockIds = new List<long> { 24046700, 24046800, 24046900, 24047000, 24047100, 24047200, 24047300, 24047400, 24047500, 24047600, 24047700 }; | ||
|
|
||
| const long LatestBlockId = 24080984; |
|
|
||
| const long LatestBlockId = 24080984; | ||
| const int BlockCount = 25; | ||
| var blockIds = Enumerable.Range((int)(LatestBlockId - BlockCount), BlockCount+1).Select(i => i).ToList(); |
There was a problem hiding this comment.
nit: generally use explicit types instead of var for clarity
| var results = await Task.WhenAll(tasks); | ||
|
|
||
| int validCount = results.Count(r => r == 1); | ||
| int totalCount = results.Count(r => r != -1); // Exclude skipped proofs |
There was a problem hiding this comment.
no need to iterate twice here
| int totalCount = results.Count(r => r != -1); // Exclude skipped proofs | ||
|
|
||
| Console.WriteLine(" -----------------------------"); | ||
| Console.WriteLine((double)validCount / totalCount >= 0.5 |
There was a problem hiding this comment.
nit: could use int arithmetic
|
|
||
| private async Task<int> ProcessProofAsync(ProofMetadata proof, ZkProofVerifier? verifier) | ||
| { | ||
| if (verifier == null) |
There was a problem hiding this comment.
| if (verifier == null) | |
| if (verifier is null) |
| Console.WriteLine($" Proof {proof.ProofId,-10} : {(isValid ? "✅ Valid" : "❌ Invalid")} ({verifier.ZkType}, {sw.ElapsedMilliseconds} ms)"); | ||
| return isValid ? 1 : 0; | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
catch specific exception type
| : $"❌ BLOCK #{blockId} REJECTED ({validCount}/{totalCount})"); | ||
| } | ||
|
|
||
| private async Task<int> ProcessProofAsync(ProofMetadata proof, ZkProofVerifier? verifier) |
There was a problem hiding this comment.
returning enum type seems clearer than int here
| { | ||
| return await _httpClient.GetFromJsonAsync<List<ClusterVerifier>>("/api/v0/verification-keys/active"); | ||
| } | ||
| catch (Exception ex) |
|
|
||
| public ZkProofVerifier? GetVerifier(string clusterId) | ||
| { | ||
| _verifiers.TryGetValue(clusterId, out var verifier); |
There was a problem hiding this comment.
handle case where not found in dictionary?
There was a problem hiding this comment.
the method is intentionally designed to return null to indicate a cache miss. This allows the caller (i.e. BlockValidator) to handle the missing verifier by calling TryAddVerifierAsync, which performs the lazy-loading of verification keys from the API
…cessing with detailed results and error handling
2 participants
Changes
This PR introduces an initial approach for a proof of concept (PoC) tool,
EthProofValidator, located insrc/tools. This tool is designed to validate Ethereum block proofs aggregated by https://ethproofs.org/Key additions:
EthProofValidator): Orchestrates the fetching of proofs from the Ethproofs API and acts as a wrapper for verification.native-zk-verifier): A native library that implements the actual cryptographic verification logic using various zkVM SDKs (SP1, Pico, OpenVM, Zisk).P/Invoketo bridge the .NET application with the Rust-based verifiers.Workflow:
ethproofs.org.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
Documentation
Requires documentation update
A
README.mdhas been included within thetools/EthProofValidatordirectory explaining the project structure and build/run instructions.Requires explanation in Release Notes
Remarks
native-zk-verifierlibrary.EthProofValidator.csprojautomatically detects the OS (Linux/Windows/OSX) to load the correct shared library extension (.so,.dll,.dylib).